Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide IOSWriter & IConsoleWriter from the public interface #2

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

ns-vasilev
Copy link
Member

No description provided.

@ns-vasilev ns-vasilev self-assigned this Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (22928c2) 91.84% compared to head (f013ca5) 92.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev       #2      +/-   ##
==========================================
+ Coverage   91.84%   92.86%   +1.02%     
==========================================
  Files           9       10       +1     
  Lines          98      126      +28     
==========================================
+ Hits           90      117      +27     
- Misses          8        9       +1     
Files Coverage Δ
...ces/Log/Classes/Core/Printers/ConsolePrinter.swift 100.00% <100.00%> (ø)
Sources/Log/Classes/Core/Printers/OSPrinter.swift 100.00% <100.00%> (ø)
.../Helpers/Writers/ConsoleWriter/ConsoleWriter.swift 100.00% <100.00%> (+100.00%) ⬆️
...riters/OSWriter/Strategies/IOSWriterStrategy.swift 100.00% <100.00%> (ø)
...og/Classes/Helpers/Writers/OSWriter/OSWriter.swift 57.14% <57.14%> (+57.14%) ⬆️

@ns-vasilev ns-vasilev changed the title Hide IOSWriter & IConsoleWriter from public interface Hide IOSWriter & IConsoleWriter from the public interface Jan 18, 2024
The test just checks that the methods don't cause a crash when printing a message to different outputs.
@ns-vasilev ns-vasilev merged commit 2c6cf2f into dev Jan 19, 2024
17 checks passed
@ns-vasilev ns-vasilev deleted the feature/refactoring branch January 19, 2024 07:08
ns-vasilev added a commit that referenced this pull request Jan 19, 2024
* Hide some implementation details

* Update `CHANGELOG.md`

* Add a test

The test just checks that the methods don't cause a crash when printing a message to different outputs.

* Update `codecov.yml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant